On Thu, Oct 17, 2024 at 04:15:02PM +0530, Anuj Gupta wrote: > On Thu, Oct 17, 2024 at 10:00:15AM +0200, Christoph Hellwig wrote: > > On Wed, Oct 16, 2024 at 04:59:07PM +0530, Anuj Gupta wrote: > > > Add flags to describe checks for integrity meta buffer. These flags are > > > specified by application as io_uring meta_flags, added in the next patch. > > > > These are now blkdev uapis, but io_uring ones even if currently only > > the block file operations implement them. I do plan to support these > > through file systems eventually. > > Are these flags placed correctly here or you see that they should be > moved somewhere else? They are not as they aren't blkdev apis. They are generic for io_uring, or maybe even VFS-wide.