On Tue, Oct 15, 2024 at 09:01:41AM +0000, John Garry wrote: > Validate that an atomic write adheres to length/offset rules. Currently > we can only write a single FS block. > + if (iocb->ki_flags & IOCB_ATOMIC) { > + if (ocount != ip->i_mount->m_sb.sb_blocksize) > + return -EINVAL; Maybe throw in a comment here why we are currently limited to atomic writes of exactly the file system block size and don't allow smaller values. Otherwise this looks good to me.