On 10/9/24 6:41 AM, Christoph Hellwig wrote: >> // A silly nit: it seems the code uses blk_queue_flag_set() and >> // blk_queue_flag_clear() helpers, but there is no queue_flag_test(), >> // I don't know what if the preference here - stick to queue_flag >> // helpers, or is it ok to mix them. > > Yeah. I looked into a test_and_set wrapper, but then saw how pointless > the existing wrappers are. So for now this just open codes it, and > once we're done with the fixes I plan to just send a patch to remove > the wrappers entirely. Agree, but that's because you didn't do it back when you changed them to be just set/clear bit operations ;-). They should definitely just go away now. -- Jens Axboe
