On 09/10/24 13:00, Christoph Hellwig wrote:
The patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
On Tue, Oct 08, 2024 at 11:22:15PM +0530, SurajSonawane2415 wrote:
Fix the uninitialized symbol 'bio' in the function blk_rq_prep_clone
to resolve the following error:
block/blk-mq.c:3199 blk_rq_prep_clone() error: uninitialized symbol 'bio'.
To make this more readable I'd usually keep and empty line before
the actual error message. But more importantly it would be useful
to explain what tool generated said error message, and maybe also add
a summary of the discussion why this function was in many ways
pretty horrible code.
Thank you for the review and suggestions.
Should I submit a new version with the added empty line and explanation
about the tool and function issues?
Best regards,
Suraj Sonawane
