On Tue, Oct 08, 2024 at 04:55:03PM +0200, Matias Bjørling wrote: > + if (info->is_rotational) > + lim.features |= BLK_FEAT_ROTATIONAL | BLK_FEAT_ADD_RANDOM; Entropy from block devices is pretty useless. The only reason we still keep it for SCSI is because of retro-computing platforms without a proper platform hardware RNG. NVMe HDDs reall should not show up in those kinds of environments. Also without a add_disk_randomness in the nvme I/O completion handler this won't actually do anything.