On Tue, Oct 08, 2024 at 08:52:07AM -0600, Keith Busch wrote: > I think your commit message is missing the real "fix" here. The other > place that goto's this label is if blk_crypto_rq_bio_prep() fails. At > this point, the cloned 'rq' has all the bio's that get cleaned up in > blk_rq_unprep_clone(), so that failure scenario is double put'ing the > last bio. Ah, forget that. The existing code was NULL'ing the bio before prep_clone, so the scenario I described doesn't happen.
