On 10/8/24 13:20, Christoph Hellwig wrote: > On Tue, Oct 08, 2024 at 07:48:10AM +0900, Damien Le Moal wrote: >> Yes, ->load_module() should return 0 on success and negative error code on >> error. Otherwise, a positive error may be interpreted by user space as a success >> write to the sysfs attribute. Adding a comment for that will be good too. >> >> Care to send a patch ? > > It should not return anything at all as alreaday said last round. > Jens just asked for that to be sent layer, so I guess I'll do it now. Ah, yes, that is even better. -- Damien Le Moal Western Digital Research