On 10/6/24 8:07 AM, kernel test robot wrote: > > > Hello, > > kernel test robot noticed "blktests.block/024.fail" on: > > commit: 5b0b8be85f1ca1c11566890f5d4564ee97cf2d41 ("[PATCH] block: move iostat check into blk_acount_io_start()") > url: https://github.com/intel-lab-lkp/linux/commits/Jens-Axboe/block-move-iostat-check-into-blk_acount_io_start/20241003-032648 > base: https://git.kernel.org/cgit/linux/kernel/git/axboe/linux-block.git for-next > patch link: https://lore.kernel.org/all/550fc8a0-3461-49ac-879e-32908870f007@xxxxxxxxx/ > patch subject: [PATCH] block: move iostat check into blk_acount_io_start() > > in testcase: blktests > version: blktests-x86_64-80430af-1_20240910 > with following parameters: > > disk: 1HDD > test: block-024 This should fix it: diff --git a/block/blk-mq.c b/block/blk-mq.c index 8e75e3471ea5..9cbc0262ad19 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -331,7 +331,7 @@ EXPORT_SYMBOL(blk_rq_init); /* Set start and alloc time when the allocated request is actually used */ static inline void blk_mq_rq_time_init(struct request *rq, u64 alloc_time_ns) { - if (blk_mq_need_time_stamp(rq)) + if (blk_queue_io_stat(rq->q)) rq->start_time_ns = blk_time_get_ns(); else rq->start_time_ns = 0; -- Jens Axboe