Hi Jens, On Wed, Oct 02, 2024 at 07:17:28AM -0600, Jens Axboe wrote: > > On Wed, 02 Oct 2024 11:54:58 +0800, Chun-Yi Lee wrote: > > For fixing CVE-2023-6270, f98364e92662 ("aoe: fix the potential > > use-after-free problem in aoecmd_cfg_pkts") makes tx() calling dev_put() > > instead of doing in aoecmd_cfg_pkts(). It avoids that the tx() runs > > into use-after-free. > > > > Then Nicolai Stange found more places in aoe have potential use-after-free > > problem with tx(). e.g. revalidate(), aoecmd_ata_rw(), resend(), probe() > > and aoecmd_cfg_rsp(). Those functions also use aoenet_xmit() to push > > packet to tx queue. So they should also use dev_hold() to increase the > > refcnt of skb->dev. > > > > [...] > > Applied, thanks! > > [1/1] aoe: fix the potential use-after-free problem in more places > commit: 6d6e54fc71ad1ab0a87047fd9c211e75d86084a3 > Thanks for your review! Joey Lee