On 10/3/24 7:00 AM, Christoph Hellwig wrote: > On Wed, Oct 02, 2024 at 02:07:44PM -0700, Keith Busch wrote: >> + accounting of the disk. Set to 0 to disable all stats. Set to 1 >> + to enable block IO stats. Set to 2 to enable passthrough stats >> + in addition to block IO. > > Jens' reply suggest he likes this interface, but I have to say I > already hated it with a passion for the merges - overloading a > previously boolean file with a numberic value is not exactly an > intuitive interface. Is a new sysfs file for this really a problem? We can do a new file as well, like iostats_passthrough. Don't really feel strongly about that part. -- Jens Axboe
