On 9/24/24 08:38, Shinichiro Kawasaki wrote:
On Sep 23, 2024 / 08:31, Hannes Reinecke wrote:
[...]
How utterly curious.
This mentioned patch moves some sysfs attributes to a different location in
the code. The stacktrace you've posted indicates that we're creating a
controller while the previous one is still present in sysfs, ie that the
lifetime of the controller has changed.
I find it difficult to understand how the cited path could have changed
the lifetime of the controller object, but will continue to check.
I tried to recreate the failure, and observed a very similar but different
symptom. Kernel reported the KASAN BUG global-out-of-bounds, in
create_files() [3]. I confirmed that this symptom is triggered with the commit
1e48b34c9bc7.
[ .. ]
diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
index eb345551d6fe..b68a9e5f1ea3 100644
--- a/drivers/nvme/host/sysfs.c
+++ b/drivers/nvme/host/sysfs.c
@@ -767,6 +767,7 @@ static struct attribute *nvme_tls_attrs[] = {
&dev_attr_tls_key.attr,
&dev_attr_tls_configured_key.attr,
&dev_attr_tls_keyring.attr,
+ NULL,
};
static umode_t nvme_tls_attrs_are_visible(struct kobject *kobj,
Oh, indeed. That'll be the correct fix.
Care to send an official patch?
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
