Re: [PATCH 0/2] Add BLK_FEAT_READ_SYNCHRONOUS and SWP_READ_SYNCHRONOUS_IO

To: Qun-Wei Lin <qun-wei.lin@xxxxxxxxxxxx>
Subject: Re: [PATCH 0/2] Add BLK_FEAT_READ_SYNCHRONOUS and SWP_READ_SYNCHRONOUS_IO
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 19 Sep 2024 04:37:29 -0700
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Ryan Roberts <ryan.roberts@xxxxxxx>, "Huang, Ying" <ying.huang@xxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Chris Li <chrisl@xxxxxxxxxx>, "Matthew Wilcox (Oracle)" <willy@xxxxxxxxxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Dan Schatzberg <schatzberg.dan@xxxxxxxxx>, Kairui Song <kasong@xxxxxxxxxxx>, Barry Song <baohua@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, Casper Li <casper.li@xxxxxxxxxxxx>, Chinwen Chang <chinwen.chang@xxxxxxxxxxxx>, Andrew Yang <andrew.yang@xxxxxxxxxxxx>, John Hsu <john.hsu@xxxxxxxxxxxx>, wsd_upstream@xxxxxxxxxxxx
In-reply-to: <20240919112952.981-1-qun-wei.lin@mediatek.com>
References: <20240919112952.981-1-qun-wei.lin@mediatek.com>

Well, you're not actually setting your new flags anywhere, which -
as you might know - is an reson for an insta-NAK.

Follow-Ups:
- Re: [PATCH 0/2] Add BLK_FEAT_READ_SYNCHRONOUS and SWP_READ_SYNCHRONOUS_IO
  - From: Chris Li

References:
- [PATCH 0/2] Add BLK_FEAT_READ_SYNCHRONOUS and SWP_READ_SYNCHRONOUS_IO
  - From: Qun-Wei Lin