Re: [PATCH 2/7] sched: change wake_up_bit() and related function to expect unsigned long *

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 26, 2024 at 04:30:59PM +1000, NeilBrown wrote:
> wake_up_bit() currently allows a "void *".  While this isn't strictly a
> problem as the address is never dereferenced, it is inconsistent with
> the corresponding wait_var_event() which requires "unsigned long *" and
> does dereference the pointer.

I'm having trouble parsing this. The way I read it, you're contradicting
yourself. Where does wait_var_event() require 'unsigned long *' ?

> And code that needs to wait for a change in something other than an
> unsigned long would be better served by wake_up_var().

This, afaict the whole var thing is size invariant. It only cares about
the address.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux