On Thu, Apr 20, 2017 at 03:38:49PM +1000, NeilBrown wrote: > pktcdvd doesn't change the bi_io_vec of the clone bio, > so it is more efficient to use bio_clone_fast(), and not clone > the bi_io_vec. > This requires providing a bio_set, and it is safest to > provide a dedicated bio_set rather than sharing > fs_bio_set, which filesytems use. > This new bio_set, pkt_bio_set, can also be use for the bio_split() > call as the two allocations (bio_clone_fast, and bio_split) are > independent, neither can block a bio allocated by the other. Looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But didn't we decide we want to kill off pktcdvd a while ago?