> @@ -176,7 +176,7 @@ static void blk_validate_atomic_write_limits(struct queue_limits *lim) > { > unsigned int boundary_sectors; > > - if (!lim->atomic_write_hw_max) > + if (!(lim->features & BLK_FEAT_ATOMIC_WRITES) || !lim->atomic_write_hw_max) Overly long line here. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>