Re: [PATCH v5 5/8] block: implement async io_uring discard cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> + * io_uring block file commands, see IORING_OP_URING_CMD.
> + * It's a different number space from ioctl(), reuse the block's code 0x12.
> + */
> +#define BLOCK_URING_CMD_DISCARD			_IO(0x12, 0)

Please just start out at some arbitrary boundary, but don't reuse
the ioctl code from an ioctl that does something vaguely similar for
no good reason.

The rest looks good.




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux