On Sep 07, 2024 / 14:37, Yi Zhang wrote:
> On Fri, Sep 6, 2024 at 4:22 PM Shinichiro Kawasaki
> <shinichiro.kawasaki@xxxxxxx> wrote:
> >
> > On Sep 02, 2024 / 19:54, Shin'ichiro Kawasaki wrote:
> > > The CKI project reported that the test case nvme/052 fails occasionally
> > > with the errors below:
> > [...]
> > > To avoid the failure, wait for the namespace removal before recreating
> > > the namespace. Modify nvmf_wait_for_ns() so that it can wait for
> > > namespace creation and removal. Call nvmf_wait_for_ns() for removal
> > > after _remove_nvmet_ns() call. While at it, reduce the wait time unit
> > > from 1 second to 0.1 second to shorten test time.
> > >
> > > The test case intends to catch the regression fixed by the kernel commit
> > > ff0ffe5b7c3c ("nvme: fix namespace removal list"). I reverted the commit
> > > from the kernel v6.11-rc4, then confirmed that the test case still can
> > > catch the regression with this change.
> > >
> > > Link: https://lore.kernel.org/linux-block/tczctp5tkr34o3k3f4dlyhuutgp2ycex6gdbjuqx4trn6ewm2i@qbkza3yr5wdd/
> > > Fixes: 077211a0e9ff ("nvme: add test for creating/deleting file-ns")
> > > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> >
> > I applied the patch. Nilay, thanks for your help!
> >
>
> Thanks for the fix, I've verified the fix on the reproduced server.
Thanks for the confirmation :)
> BTW, after the change, the executing time also reduced to 7s from 22s
This runtime reduction is expected. I suggested a change for it, and it was
discussed here:
https://lore.kernel.org/linux-block/0750187c-24ad-4073-9ba1-d47b0ee95062@xxxxxxxxxxxxx/
