On Sat, Sep 07, 2024 at 07:02:30PM +0800, Ming Lei wrote: > BTW, the issue can be reproduced 100% by: > > echo "deadlock" > /sys/block/$ROOT_DISK/queue/scheduler That doesn't reproduce it for me (reliably). Although I'm not surprised as this bug has been _very_ tricky to reproduce! Sometimes I think I have a definite reproducer, only for it to go away when some tiny detail changes. > > This seems like the neatest (or shortest) fix so far, but doesn't it > > "mix up layers" by checking elv_iosched_store? > > It is just one exception for 'scheduler' sysfs attribute wrt. freezing > queue for storing, and the check can be done via the attribute > name("scheduler") too. Fair enough. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html