Hi,
在 2024/9/3 22:47, Jens Axboe 写道:
On 9/3/24 8:43 AM, Li Zetao wrote:
Since the debugfs_create_dir() never returns a null pointer, checking
the return value for a null pointer is redundant, and using IS_ERR is
safe enough.
Sigh, why are we seeing so many odd variants of this recently. If you'd
do a bit of searching upfront, you'd find that these should not be
checked at all rather than changing it from err+null to just an error
pointer check.
So no to this one, please do at least a tiny bit of research first
before blindly making a change based on what some static analyzer told
you.
I have researched in the community before making the modification.
debugfs_create_file can handle illegal dentry, but my understanding is
that verifying debugfs_create_dir when it fails can avoid invalid calls
to debugfs_create_file.
Greg suggested that I remove this check, maybe I can modify it in v2?
Thanks,
Li Zetao.
