On Thu, 2024-08-29 at 07:36 +0000, Shinichiro Kawasaki wrote: > Shellcheck reports a warning here: > > tests/nvme/053:47:9: warning: Prefer mapfile or read -a to split > command output (or quote to avoid splitting). [SC2207] > > It is a bit lengthy, but let's replace the line above with this: > > while read -r line ; do ctrls+=("$line"); done < > <(_nvme_get_ctrl_list) Thanks for the review. If you don't mind, I'll just use "mapfile -t", as suggested by shellcheck. Martin