On Tue, 2024-08-27 at 13:05 -0600, Jens Axboe wrote:
> On 8/27/24 12:56 PM, Philipp Stanner wrote:
> > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by
> > the
> > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> >
> > In mtip32xx, these functions can easily be replaced by their
> > respective
> > successors, pcim_request_region() and pcim_iomap(). Moreover, the
> > driver's calls to pcim_iounmap_regions() in probe()'s error path
> > and in
> > remove() are not necessary. Cleanup can be performed by PCI devres
> > automatically.
> >
> > Replace pcim_iomap_regions() and pcim_iomap_table().
> >
> > Remove the calls to pcim_iounmap_regions().
>
> Looks fine to me - since it depends on other trees, feel free to take
> it
> through those:
>
> Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>
Thank you for the review.
I have to provide a v5 because of an issue in another patch. While I'm
at it, I'd modify this patch here so that the comment above
pcim_request_region() is descriptive of the actual events:
- /* Map BAR5 to memory. */
+ /* Request BAR5. */
I'd keep your Reviewed-by if that's OK. It's the only change I'd do.
Regards,
P.
