On 26/08/2024 19:38, Christoph Hellwig wrote: > Hi Jens, > > this series fixes code that incorrectly splits of zoned append bios due > to checking for a wrong max_sectors limit. A big part of the cause is > that the bio splitting code is a bit of a mess and full of landmines, so > I fixed this as well. > > To hit this bug a submitter needs to submit a bio larger than max_sectors > of device, but smaller than max_hw_sectors. So far the only thing that > reproduces it is my not yet upstream zoned XFS code, but in theory this > could affect every submitter of zone append bios. > > Diffstat: > block/blk-merge.c | 162 ++++++++++++++++++++++--------------------------- > block/blk-mq.c | 11 +-- > block/blk.h | 70 +++++++++++++++------ > fs/btrfs/bio.c | 30 +++++---- > include/linux/bio.h | 4 - > include/linux/blkdev.h | 3 > 6 files changed, 153 insertions(+), 127 deletions(-) > Looks good to me, and with these patches applied the issues mentioned above goes away in my zoned xfstest setup. For this series, Tested-by: Hans Holmberg <hans.holmberg@xxxxxxx> Reviewed-by: Hans Holmberg <hans.holmberg@xxxxxxx>
