On 8/26/24 12:26 AM, Yang Ruibin wrote: > Remove the debugfs_create_dir() error check. > It's safe to pass in errors that it gives you. Please make it: Remove the debugfs_create_dir() error check. It's safe to pass in error pointers to the debugfs API, hence the user isn't supposed to include error checking of the return values. Note both the rewording, and that commit messages should be formatted to 72-74 char line lengths, not tiny ones. -- Jens Axboe