On 8/23/24 15:12, Bart Van Assche wrote: > On 8/23/24 6:49 AM, MANISH PANDEY wrote: >> while making the patch, i figured out that queue_flags is unsigned long type and we already reached up to 32 flags as of now. > > Really? In Linus' master branch I see 13 queue flags. This is less than > half of 32. From include/linux/blkdev.h: @Manish: See recent (6.11) cleanup https://lore.kernel.org/linux-block/20240719112912.3830443-1-john.g.garry@xxxxxxxxxx/ > > enum { > QUEUE_FLAG_DYING, /* queue being torn down */ > QUEUE_FLAG_NOMERGES, /* disable merge attempts */ > QUEUE_FLAG_SAME_COMP, /* complete on same CPU-group */ > QUEUE_FLAG_FAIL_IO, /* fake timeout */ > QUEUE_FLAG_NOXMERGES, /* No extended merges */ > QUEUE_FLAG_SAME_FORCE, /* force complete on same CPU */ > QUEUE_FLAG_INIT_DONE, /* queue is initialized */ > QUEUE_FLAG_STATS, /* track IO start and completion times */ > QUEUE_FLAG_REGISTERED, /* queue has been registered to a disk */ > QUEUE_FLAG_QUIESCED, /* queue has been quiesced */ > QUEUE_FLAG_RQ_ALLOC_TIME, /* record rq->alloc_time_ns */ > QUEUE_FLAG_HCTX_ACTIVE, /* at least one blk-mq hctx is active */ > QUEUE_FLAG_SQ_SCHED, /* single queue style io dispatch */ > QUEUE_FLAG_MAX > }; > > Bart. >
