Re: [PATCH v2 3/3] nvme: add test for controller rescan under I/O load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-08-26 at 11:07 +0530, Nilay Shroff wrote:
> > 
> The "rand()" function in 'awk' returns a floating point value between
> 0 and 1 (i.e. [0, 1]). So it's possible to have sleep for some cases
> go
> upto ~5.1 seconds. So if the intention is to sleep between 0.1 and 5 
> seconds precisely then we may want to use,
>  
> sleep(0.1 + 4.9 * rand());
> 

Yes, I know. I thought it didn't really matter as the 5s limit was
arbitrary anyway.

> However this is not a major problem and we may ignore. 
> Otherwise, code looks good to me.
>     
> Reviewed-by: Nilay Shroff (nilay@xxxxxxxxxxxxx)
> 

Thanks!
Martin






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux