On Fri, Aug 23, 2024 at 08:41:59AM GMT, Martin Wilck wrote:
> On Fri, 2024-08-23 at 08:35 +0200, Daniel Wagner wrote:
> > On Thu, Aug 22, 2024 at 09:38:12PM GMT, Martin Wilck wrote:
> > > +_require_test_dev_is_nvme_no_mpath() {
> > > + if [[ "$(readlink -f "$TEST_DEV_SYSFS/device")" =~ /nvme-
> > > subsystem/ ]]; then
> > > + SKIP_REASONS+=("$TEST_DEV is a NVMe multipath
> > > device")
> > > + return 1
> > > + fi
> > > + return 0
> > > +}
> >
> > Just a nit: what about _require_test_dev_is_native_multipath?
>
> The intention was to require a device that is _not_ a native multipath
> device. Change it to "_require_test_dev_is_not_native_multipath"?
I confused mpath with dm-mpath when I read the function name. Doesn't
make any sence obviously but still got me confused. I prefer the more
explicit function name you suggested. But let's here what others say.
