On Wed, Aug 21, 2024 at 08:30:26AM +0200, Christoph Hellwig wrote: > Hi all, > > I've recently been looking at the XFS fallocate implementation and got > upset about the messing parsing of the mode argument, which mixes modes > and an optional flag in a really confusing way. > > This series tries to clean this up by better defining what is the > operation mode and what is an optional flag, so that both the core > code and file systems can use switch statements to switch on the mode. For patches 4-6, Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> (I'm not going to touch the NO_HIDE_STALE pony, I'll let you and tytso mix it up over^W^W^W^Wdiscuss that...) --D