But in my honest opinion, that code is _very_ broken. I was thinking about how we might clean it up, but couldn't come up with an idea yet. Only after the code in pci/msi/ has been cleanly separated from implicit devres I myself would start touching function calls related to MSI. That being said, I suspect that one can remove pci_disable_msi() in the line above. But the risk-benefit-ratio doesn't pay off for me. P. > > > [1] > > https://lore.kernel.org/all/ee44ea7ac760e73edad3f20b30b4d2fff66c1a85.camel@xxxxxxxxxx/ >