On Thu, Aug 15, 2024 at 08:27:54AM +0000, John Garry wrote: > +/* > + * Pass bio_write_zeroes_limit() return value in @limit, as the return > + * value may change after a REQ_OP_WRITE_ZEROES is issued. > + */ I don't think that really helps all that much to explain the issue, which is about SCSI not having an ahead of time flag that reliably works for write same support, which makes it clear the limit to 0 on the first I/O completion. Maybe you can actually spell this out? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>