Re: [PATCH] ublk: move zone report data out of request pdu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 10, 2024 at 10:27 PM Jens Axboe <axboe@xxxxxxxxx> wrote:
>
> On 8/9/24 10:02 PM, Ming Lei wrote:
> > ublk zoned takes 16 bytes in each request pdu just for handling REPORT_ZONE
> > operation, this way does waste memory since request pdu is allocated
> > statically.
> >
> > Store the transient zone report data into one global xarray, and remove
> > it after the report zone request is completed. This way is reasonable
> > since report zone is run in slow code path.
>
> Oof yes, that's a lot better. I think this warrants a:
>
> Fixes: 29802d7ca33b ("ublk: enable zoned storage support")
>
> as that's a pretty big waste, especially when most would not even be
> using the zoned support.

Indeed, the patch itself is easy enough for backport, will add Fixes tag in V2.

Thanks,






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux