On Wed, Apr 19, 2017 at 08:31:42AM +0800, Ming Lei wrote: > mtip32xx supposes that 'request_idx' passed to .init_request() > is tag of the request, and use that as request's tag to initialize > command header. > > After MQ IO scheduler is in, request tag assigned isn't same with > the request index anymore, so cause strange hardware failure on > mtip32xx, even whole system panic is triggered. > > This patch fixes the issue by initializing command header via > request's real tag. This patch looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx> But we should also remove the request_idx parameter from the init_request and exit_request methods given that they can't be used once a scheduler is in use.