Hi Ofir, thank you for this v3 series. The two patches look good to me, except one unclear point below. On Jul 16, 2024 / 14:50, Ofir Gal wrote: [...] > diff --git a/tests/md/001 b/tests/md/001 > new file mode 100755 > index 0000000..e9578e8 > --- /dev/null > +++ b/tests/md/001 > @@ -0,0 +1,85 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-3.0+ > +# Copyright (C) 2024 Ofir Gal > +# > +# The bug is "visible" only when the underlying device of the raid is a network > +# block device that utilize MSG_SPLICE_PAGES. nvme-tcp is used as the network device. > +# > +# Regression test for patch "md/md-bitmap: fix writing non bitmap pages" and > +# for patch "nvme-tcp: use sendpages_ok() instead of sendpage_ok()" The cover letter of the series says that the new test case is the regression test for the patch "md/md-bitmap: fix writing non bitmap pages". On the other hand, the comment above says that this test case is for the two patches. Which is correct? (Or which is more accurate?) When I ran this test case, it failed on the kernel v6.10, which is expected. Then I applied the 1st patch "md/md-bitmap: fix writing non bitmap pages" only to the v6.10 kernel, and the test case passed. It passed without the 2nd patch "nvme-tcp: use sendpages_ok() instead of sendpage_ok()". So, I'm not sure if this test case is the regression test for the 2nd patch.
