Re: [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]

To: John Garry <john.g.garry@xxxxxxxxxx>, axboe@xxxxxxxxx, hch@xxxxxx
Subject: Re: [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Mon, 15 Jul 2024 10:28:45 -0700
Cc: linux-block@xxxxxxxxxxxxxxx
In-reply-to: <5fca6dde-bbfd-4a25-8d1d-c1257540eac4@oracle.com>
References: <20240711082339.1155658-1-john.g.garry@oracle.com> <20240711082339.1155658-5-john.g.garry@oracle.com> <b97da63e-386d-4cb0-9bf1-cfbe00154979@acm.org> <5fca6dde-bbfd-4a25-8d1d-c1257540eac4@oracle.com>
User-agent: Mozilla Thunderbird

On 7/15/24 12:54 AM, John Garry wrote:

BTW, BLK_MQ_CPU_WORK_BATCH is only used in block/blk-mq.c, so I don'tsee why it is even in a public API.


I'm in favor of moving this constant into block/blk-mq.c.

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]
  - From: John Garry

References:
- [PATCH v2 00/12] block: Catch missing debugfs flag array members
  - From: John Garry
- [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]
  - From: John Garry
- Re: [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]
  - From: Bart Van Assche
- Re: [PATCH v2 04/12] block: Catch possible entries missing from hctx_state_name[]
  - From: John Garry