On 09/07/2024 12:23, Christoph Hellwig wrote:
+enum {
+ /* drive already may have started this one */
+ RQF_STARTED = ((__force req_flags_t)(1 << 0)),
Last time I tried to mix __bitwise and enums sparse was very unhappy.
Did this get fixed?
For me, sparse only complains about RQF_MAX, which is added later.
But, as I noted, I think that needs to change to a bit count from a flag
anyway. I am not sure how that would look, maybe:
enum {
RQF_STARTED_BIT = 0,
...
RQF_MAX_BITS
};
and then use a macro to define RQF_STARTED as ((__force
req_flags_t)(RQF_STARTED_BIT << 0))
But do you remember how you generated the sparse warning specifically?