On 7/6/24 12:22 AM, Christoph Hellwig wrote: > On Sat, Jul 06, 2024 at 12:21:06AM -0600, Jens Axboe wrote: >>> /** >>> - * get_max_segment_size() - maximum number of bytes to add as a single segment >>> + * get_max_segment_size() - maximum number of bytes to add to a single segment >> >> v1 had this change too, not sure why? The previous description seems >> better than the changed one. > > Because it is used to also append data from another bio_vec to a > pre-existing SG segment, not just to create new ones. Sure, but then let's make it something that makes more sense at least. Maximum size to consider as a single segment, or something like that. -- Jens Axboe
