On Fri, Jul 05, 2024 at 02:25:59PM +0100, John Garry wrote:
> On 05/07/2024 13:56, Christoph Hellwig wrote:
>> Extend the checks added in 0676c434a99b ("block: check bio alignment
>> in blk_mq_submit_bio") for blk-mq drivers to bio based drivers as
>> all the same reasons apply for them as well.
>
> So do we now still need blkdev_dio_invalid() -> bdev_logical_block_size()
> pos checks for simple and async paths in fops?
>
> They are not doing harm and messy to remove, I suppose (if strictly not
> required).
Going all the way down into the block layer vs just doing the trivial
check ahead of time does not sound like a winning proposition..
