Hi Christoph, On Fri, Jul 5, 2024 at 10:15 AM Christoph Hellwig <hch@xxxxxx> wrote: > Work on a single address to simplify the logic, and prepare the callers > from using better helpers. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Thanks for your patch! > --- a/block/blk-merge.c > +++ b/block/blk-merge.c > @@ -207,25 +207,22 @@ static inline unsigned get_max_io_size(struct bio *bio, > } > > /** > - * get_max_segment_size() - maximum number of bytes to add as a single segment > + * get_max_segment_size() - maximum number of bytes to add to a single segment > * @lim: Request queue limits. > - * @start_page: See below. > - * @offset: Offset from @start_page where to add a segment. > + * @paddr: address of the range to add > * > - * Returns the maximum number of bytes that can be added as a single segment. > + * Returns the maximum number of bytes of the range starting at @addr that can @paddr > + * be added to a single request. > */ Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds