Re: [PATCH] bcache: work around a __bitwise to bool conversion sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 28, 2024 at 03:16:48PM +0200, Christoph Hellwig wrote:
> Sparse is a bit dumb about bitwise operation on __bitwise types used
> in boolean contexts.  Add a !! to explicitly propagate to boolean
> without a warning.
> 
> Fixes: fcf865e357f8 ("block: convert features and flags to __bitwise types")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Acked-by: Kent Overstreet <kent.overstreet@xxxxxxxxx>

> ---
>  drivers/md/bcache/super.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 283b2511c6d21f..b5d6ef430b86fc 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1416,8 +1416,8 @@ static int cached_dev_init(struct cached_dev *dc, unsigned int block_size)
>  	}
>  
>  	if (bdev_io_opt(dc->bdev))
> -		dc->partial_stripes_expensive = q->limits.features &
> -			BLK_FEAT_RAID_PARTIAL_STRIPES_EXPENSIVE;
> +		dc->partial_stripes_expensive = !!(q->limits.features &
> +			BLK_FEAT_RAID_PARTIAL_STRIPES_EXPENSIVE);
>  
>  	ret = bcache_device_init(&dc->disk, block_size,
>  			 bdev_nr_sectors(dc->bdev) - dc->sb.data_offset,
> -- 
> 2.43.0
> 




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux