RE: [PATCH blktests v2] loop/010: do not assume /dev/loop0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shinichiro,

Thank you very much for working on improving the test case.

Regards,
Gulam Mohamed.

> -----Original Message-----
> From: Shinichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> Sent: Friday, June 28, 2024 3:41 PM
> To: linux-block@xxxxxxxxxxxxxxx
> Cc: Gulam Mohamed <gulam.mohamed@xxxxxxxxxx>; Chaitanya Kulkarni
> <kch@xxxxxxxxxx>
> Subject: Re: [PATCH blktests v2] loop/010: do not assume /dev/loop0
> 
> On Jun 25, 2024 / 20:20, Shin'ichiro Kawasaki wrote:
> > The current implementation of the test case loop/010 assumes that the
> > prepared loop device is /dev/loop0, which is not always true. When
> > other loop devices are set up before the test case run, the assumption
> > is wrong and the test case fails.
> >
> > To avoid the failure, use the prepared loop device name stored in
> > $loop_device instead of /dev/loop0. Adjust the grep string to meet the
> > device name. Also use "losetup --detach" instead of "losetup
> > --detach-all" to not detach the loop devices which existed before the
> > test case runs.
> >
> > Fixes: 1c4ae4fed9b4 ("loop: Detect a race condition between loop
> > detach and open")
> > Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> 
> FYI, this fix has got applied.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux