On Thu, Jun 27, 2024 at 09:50:39PM +0100, Daniel Golle wrote: > + /* > + * In case 'uuid' is defined in the partitions firmware node require > + * partition meta info being present and the specified uuid to match. > + */ Overly long lines, which is really annyoing for block comments. > + got_uuid = !fwnode_property_read_string(fw_part, "uuid", &uuid); > + if (got_uuid && (!bdev->bd_meta_info || > + !part_meta_match(uuid, bdev->bd_meta_info->uuid, > + PARTITION_META_INFO_UUIDLTH))) Can we please not use the crazy part_meta stuff for anything new? We should never have merge it, and right now it is at least isolated to the boot time root dev_t partsing, and I'd really prefer to keep it in that corner.
