Re: [PATCH 1/3] block: simplify queue_logical_block_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
Subject: Re: [PATCH 1/3] block: simplify queue_logical_block_size
From: John Garry <john.g.garry@xxxxxxxxxx>
Date: Thu, 27 Jun 2024 13:09:08 +0100
Cc: linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20240627111407.476276-2-hch@lst.de>
Organization: Oracle Corporation
References: <20240627111407.476276-1-hch@lst.de> <20240627111407.476276-2-hch@lst.de>
User-agent: Mozilla Thunderbird

On 27/06/2024 12:14, Christoph Hellwig wrote:

queue_logical_block_size is never called with a 0 queue, and the


nit: could use NULL queue

logical_block_size field in queue_limits is always initialized for
a live queue.

Signed-off-by: Christoph Hellwig<hch@xxxxxx>


Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>

References:
- de-duplicate the block sysfs code
  - From: Christoph Hellwig
- [PATCH 1/3] block: simplify queue_logical_block_size
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH blktests v3 0/3] Add support to run against real target
Next by Date: Re: [PATCH v2 05/10] block: introduce BIP_CLONED flag
Previous by thread: [PATCH 1/3] block: simplify queue_logical_block_size
Next by thread: [PATCH 2/3] block: add helper macros to de-duplicate the queue sysfs attributes
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID] [Linux SCSI] [Linux ATA RAID] [IDE] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Device Mapper]

Powered by Linux