Re: [PATCH 3/7] block: rename BLK_FLAG_MISALIGNED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 25, 2024 at 12:24:07PM +0100, John Garry wrote:
> On 25/06/2024 12:05, Christoph Hellwig wrote:
> > @@ -351,7 +351,7 @@ static int blk_validate_limits(struct queue_limits *lim)
> >   	if (lim->alignment_offset) {
> >   		lim->alignment_offset &= (lim->physical_block_size - 1);
> > -		lim->features &= ~BLK_FEAT_MISALIGNED;
> > +		lim->features &= ~BLK_FLAG_MISALIGNED;
> 
> The comment for enum which BLK_FLAG_MISALIGNED is a member of reads
> "internal flags for queue_limits.flags", so it might help to comment why we
> clear in lim->features (if correct to do so).

Or fix that as well.  And probably move to a __bitwise type to make
sparse catch this.





[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux