On 6/20/24 03:41, Shin'ichiro Kawasaki wrote: > The current implementation of the test case loop/010 assumes that the > prepared loop device is /dev/loop0, which is not always true. When other > loop devices are set up before the test case run, the assumption is > wrong and the test case fails. > > To avoid the failure, use the prepared loop device name stored in > $loop_device instead of /dev/loop0. Adjust the grep string to meet the > device name. Also use "losetup --detach" instead of > "losetup --detach-all" to not detach the loop devices which existed > before the test case runs. > > Fixes: 1c4ae4fed9b4 ("loop: Detect a race condition between loop detach and open") > Signed-off-by: Shin'ichiro Kawasaki<shinichiro.kawasaki@xxxxxxx> Looks good. Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx> -ck