> + req->ioprio = ioprio_valid(bio_prio(bio)) ? bio_prio(bio) : ioc ? > + ioc->ioprio : IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0); I think this would be a tad cleaner with a traditional if / else if / else chain, e.g. if (ioprio_valid(bio_prio(bio))) req->ioprio = bio_prio(bio); else if (ioc) req->ioprio = ioc->ioprio; else req->ioprio = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_NONE, 0); But otherwise the patch looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>