On Tue, Jun 18, 2024 at 03:58:54PM +0800, Yu Kuai wrote: > There is already bigger helper blkg_conf_prep() exported, as used by bfq > for a long time already, and this helper is introduced for code > optimization, as iocost configuration doesn't need to access the blkg. > > Perhaps this should be another discussion about "design mistakes", > however, I'm not sure why. :( Do you have previous discussions? blkg_conf_prep at least has some level of abstraction. But at least my conclusion is: don't make blk-iocost modular. It's far too messy to split out, and not really worth it.