Re: [PATCHv3 blktests] nvme: add test for creating/deleting file-ns

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 19, 2024 at 04:16:40PM GMT, Nilay Shroff wrote:
> +	# start iteration from ns-id 2 because ns-id 1 is created
> +	# by default when nvme target is setup. Also ns-id 1 is
> +	# deleted when nvme target is cleaned up.
> +	for ((i = 2; i <= iterations; i++)); do {
> +		truncate -s "${NVME_IMG_SIZE}" "$(_nvme_def_file_path).$i"
> +		_create_nvmet_ns "${def_subsysnqn}" "${i}" "$(_nvme_def_file_path).$i"
> +
> +		# allow async request to be processed
> +		sleep 1

This looks a bit fragile to ensure all request have been processed. Would
it possible to wait on a state?  E.g. something like

  nvmf_wait_for_state()

?

> +
> +		_remove_nvmet_ns "${def_subsysnqn}" "${i}"
> +		rm "$(_nvme_def_file_path).$i"
> +	}




[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux