On Jun 05, 2024 / 20:01, Yi Zhang wrote: > On Wed, Jun 5, 2024 at 7:52 PM Shinichiro Kawasaki > <shinichiro.kawasaki@xxxxxxx> wrote: > > > > On Jun 04, 2024 / 21:05, Yi Zhang wrote: > > > null-blk currently power/submit_queues operations which will lead kernel > > > null-ptr-dereference[1], add one regression test for it and the fix has > > > been merged to v6.10-rc1 by [2]. > > > [1] > > > https://lore.kernel.org/linux-block/CAHj4cs9LgsHLnjg8z06LQ3Pr5cax-+Ps+xT7AP7TPnEjStuwZA@xxxxxxxxxxxxxx/ > > > https://lore.kernel.org/linux-block/20240523153934.1937851-1-yukuai1@xxxxxxxxxxxxxxx/ > > > [2] > > > commit a2db328b0839 ("null_blk: fix null-ptr-dereference while configuring 'power' and 'submit_queues'") > > > > Thank you Yi. I ran the test case and it looks working good. It passes with > > the kernel v6.10-rc2. It causes the hang with the kernel v6.9. To not confuse > > blktests users with the hang, I will wait for the commit a2db328b0839 to land on > > the stable kernels before I apply this patch. > > > > One more thing I noticed is that your current patch requires loadable null_blk. > > To allow it run with built-in null_blk, I would like to suggest additional > > change below on top of your patch. It, > > > > - calls _have_null_blk instead of _have_module null_blk, > > - checks submit_queues parameter with _have_null_blk_feature instead of > > _have_module_param, > > - does not call _init_null_blk, and > > - uses nullb1 instead for nullb0. > > > > Please let me know your thought about these changes. If you are ok with them, I > > can fold them in the commit. > > Sure, I'm OK with the change, thanks. :) Now the kernel side fix is in v6.9.4 kernel. I've applied this blktests patch. Thanks! FYI, I added my modification as a following commit [*]. [*] https://github.com/osandov/blktests/commit/eba35aaf32ceb9516a7dbc856c9db4d0ae3268d0
