On 6/11/24 14:28, Ming Lei wrote:
On Mon, Jun 10, 2024 at 02:23:50AM +0100, Pavel Begunkov wrote:
On 5/11/24 01:12, Ming Lei wrote:
Prepare for supporting sqe group, which requires to post group leader's
CQE after all members' CQEs are posted. For group leader request, we can't
do that in io_req_complete_post, and REQ_F_CQE_SKIP can't be set in
io_free_req().
Can you elaborate what exactly we can't do and why?
group leader's CQE is always posted after other members are posted.
So move marking REQ_F_CQE_SKIP out of io_free_req().
That makes io_free_req() a very confusing function, it tells
that it just frees the request but in reality can post a
CQE. If you really need it, just add a new function.
io_free_req() never posts CQE.
Right, that's the intention and that's why it sets
REQ_F_CQE_SKIP. Without it, even if you patch all call sites
that they set it themselves, it turns into a misleading
function.
This patch can help to move setting REQ_F_CQE_SKIP around
real post code, and it can make current code more readable.
--
Pavel Begunkov
