Hi Daniel, On Jun 12, 2024 / 13:04, Daniel Wagner wrote: > I've updated this series and added a simple example how to use it. I didn't > really know where to put it, so I added this part to new directorty called > 'contrib'. I'm fine with this. Some other helper scripts maybe go into the contrib directory in the future. > > Don't know if we want to keep adding environment variables for this or if it > would be simpler to pass in a configuration file. The environemnt variable are > fairly simple to handle and it works. Adding a configuraiton file adds more code > to blktests. The first patch added 4 new environemnt variables. Unless you plan to add more, I think it's fine with the environemnt variable approach. Overall, the changes do not affect core part of blktests. This looks good to me. I'm not sure if the NVME_TARGET_CONTROL script command line interface will be stable or not (setup/cleanup, --subsysnqn, --subsys-uuid and --hostnqn options). I wonder the disucssion with Hannes may affect it.
