Re: [PATCH RFC -next 1/7] kernfs: export pr_cont_kernfs_path()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

在 2024/06/13 13:55, Greg KH 写道:
On Thu, Jun 13, 2024 at 09:49:31AM +0800, Yu Kuai wrote:
From: Yu Kuai <yukuai3@xxxxxxxxxx>

This helper is used in iocost, prepare to build iocost as kernel module.

Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
---
  fs/kernfs/dir.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/fs/kernfs/dir.c b/fs/kernfs/dir.c
index 458519e416fe..84ad163a4281 100644
--- a/fs/kernfs/dir.c
+++ b/fs/kernfs/dir.c
@@ -279,6 +279,7 @@ void pr_cont_kernfs_path(struct kernfs_node *kn)
  out:
  	spin_unlock_irqrestore(&kernfs_pr_cont_lock, flags);
  }
+EXPORT_SYMBOL_GPL(pr_cont_kernfs_path);

This isn't the helper that needs to be exported, it's a include wrapper
that is using this for cgroups.  Please document this much better and
perhaps, just fix up the cgroups code instead?

Thanks for the notice, I didn't think much of this, just export API that
is called from iocost. I'll look into this.

Thanks,
Kuai


thanks,

greg k-h
.






[Index of Archives]     [Linux RAID]     [Linux SCSI]     [Linux ATA RAID]     [IDE]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Device Mapper]

  Powered by Linux